stdout/stderror log appenders are broken

[MikeSeth]

Trying to use stdout/stderror log appenders which rely on the php://foo naming convention for PHP streams results in:

Fatal error: Uncaught exception 'AgaviLoggingException' with message 'Cannot open file "php://stderr", please check permissions on file or directory.' in /usr/share/php/agavi/logging/AgaviFileLoggerAppender.class.php:75

Stack trace:

#0 /usr/share/php/agavi/logging/AgaviFileLoggerAppender.class.php(115): AgaviFileLoggerAppender->getHandle()

#1 /usr/share/php/agavi/logging/AgaviLogger.class.php(58): AgaviFileLoggerAppender->write(Object(AgaviLoggerMessage))

This is because in AgaviFileLoggerAppender's getHandle() no consideration is made towards the streams as the code asserts the file name passed to it is a physical file.

[MikeSeth]

Fix for the stream problem in getHandle()

[david]

Frankly, I don't think that's a proper solution to the problem. There might be other stream wrappers a person wants to use that do not support these kind of checks (is_writable() et al) either. Right?

[impl]

Here's some strange behavior:

~ % php -r 'var_dump(fopen("php://stdout", "a"));'

Warning: fopen(): cannot seek on a pipe in Command line code on line 1
resource(5) of type (stream)

The PHP manual states that the php:// stream wrapper supports php://stdout, php://stderr, php://output, php://memory and php://temp for appending. Seems like it should be able to do this without a warning. Oh well. (http://php.net/wrappers.php)

AFAIK, there's no way to tell whether a given stream supports appending or not programmatically. Which kinda sucks. Anyway, see attached -- not tested, but seems like an okay solution to me.

[david]

(In [2522]) Fix #751: stdout/stderror log appenders are broken. To achieve this properly, I refactored AgaviLoggerAppender? to be an AgaviParameterHolder? (closes #774) and introduced an intermediate AgaviStreamLoggerAppender? to abstract things properly (closes #773). Just for the record, the error only appeared on Linux ;) so we now use "w" instead of "a" flags for std* fopen() calls.

[david]

(In [3397]) comment with url of PHP bug ticket explaining why we use "w" and not "a" modes for stdout and stderr logger appenders, refs #751